-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wheel building with scikit build core #3087
base: develop
Are you sure you want to change the base?
Conversation
for anyone interested in wheels that contain DAGMC, Double Down, Embree and Moab options in the OpenMC executable then I have that working on this branch, clone or checkout that branch |
just to note a new pip version is needed to pass in cmake arguments via the command line, if you get this error then upgrade pip (I'm using version 24.1.2)
solve with
|
nice the docs on readthedocs are now working, it needed a bit of tweaking as they now installing the package with this scikit build core method. |
openmc/openmc_exec.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, we may not need this file.
Description
Just making this PR to show a bit of progress with the production of wheels using scikit build core. Tagging @hassec as he made the
OpenMCExtension
part of this PR.Running
pip install .
in the root folder of this repo and this will compile openmc and build a wheel and then install the python package and openmc executable from the wheel with default cmake args.It is also possible to pass in cmake args via the command line in the same line as the pip install command.
you can also run
pip install . --no-clean
This will do the same but it won't delete the wheel afterwards. This allows you to inspect the wheel and manually install from the wheel. The path to the wheel is printed to the terminal and will be in your /tmp folderI've added some
if(SKBUILD)
statements to the CMakeLists.txt to help insure the new commands only run if the process is being driven by Scikit build core and therefore this preserves the current behavior when someone wants to build the executable with cmakeI can follow up this PR to include ciwheelbuilder to make wheels for different OS versions
Fixes # (issue)
Checklist