Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8342988: GHA: Build JTReg in single step #1269

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Dec 18, 2024

WIP. Makes sure GHA is more reliable. The original PR does not apply cleanly, because Alpine support added by JDK-8282944 is not in JDK 21.

Additional testing:

  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342988 needs maintainer approval

Issue

  • JDK-8342988: GHA: Build JTReg in single step (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1269/head:pull/1269
$ git checkout pull/1269

Update a local copy of the PR:
$ git checkout pull/1269
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1269

View PR using the GUI difftool:
$ git pr show -t 1269

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1269.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 18, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport 88dc655a6d6cfc71c467405b62bd35beeed7794f 8342988: GHA: Build JTReg in single step Dec 18, 2024
@openjdk
Copy link

openjdk bot commented Dec 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant