-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8311546: Certificate name constraints improperly validated with leading period #1268
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8320372 |
@shipilev |
Both backports are actually clean. /clean |
@shipilev The |
:( Ok, then I need some reviews, please. |
Backporting this due to wider customer interest in aligning JDK behavior with other SSL implementations. Both patches apply cleanly. First patch does the fix. Second patch fixes the test.
Additional testing:
sun/security/x509/
jdk_security
Progress
Issues
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1268/head:pull/1268
$ git checkout pull/1268
Update a local copy of the PR:
$ git checkout pull/1268
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1268/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1268
View PR using the GUI difftool:
$ git pr show -t 1268
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1268.diff
Using Webrev
Link to Webrev Comment