-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8336942: Improve test coverage for class loading elements with annotations of different retentions #1037
base: master
Are you sure you want to change the base?
Conversation
…tions of different retentions Reviewed-by: vromero
👋 Welcome back cushon! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
/approval This change improves annotation processing test coverage. I resolved a trivial merge conflict with JDK-8323684, which added the nameToAnnotation map. The modified test passes. |
@cushon usage: |
/approval request This change improves annotation processing test coverage. I resolved a trivial merge conflict with JDK-8323684, which added the nameToAnnotation map. The modified test passes. |
@cushon Please first get a review, then label for approval. Thanks. |
@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Assistance progressing this pull request towards integration is welcome |
This change improves annotation processing test coverage, see JDK-8336942. I resolved a trivial merge conflict with JDK-8323684, which added the
nameToAnnotation
map. The modified test passes.Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1037/head:pull/1037
$ git checkout pull/1037
Update a local copy of the PR:
$ git checkout pull/1037
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1037/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1037
View PR using the GUI difftool:
$ git pr show -t 1037
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1037.diff
Using Webrev
Link to Webrev Comment