Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8336942: Improve test coverage for class loading elements with annotations of different retentions #1037

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

cushon
Copy link
Contributor

@cushon cushon commented Oct 8, 2024

This change improves annotation processing test coverage, see JDK-8336942. I resolved a trivial merge conflict with JDK-8323684, which added the nameToAnnotation map. The modified test passes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8336942 needs maintainer approval

Issue

  • JDK-8336942: Improve test coverage for class loading elements with annotations of different retentions (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/1037/head:pull/1037
$ git checkout pull/1037

Update a local copy of the PR:
$ git checkout pull/1037
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/1037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1037

View PR using the GUI difftool:
$ git pr show -t 1037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/1037.diff

Using Webrev

Link to Webrev Comment

…tions of different retentions

Reviewed-by: vromero
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 8, 2024

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 8, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport e36ce5f0341e8d0ec06cb12d0b2c0aa084401021 8336942: Improve test coverage for class loading elements with annotations of different retentions Oct 8, 2024
@openjdk
Copy link

openjdk bot commented Oct 8, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 8, 2024
@mlbridge
Copy link

mlbridge bot commented Oct 8, 2024

Webrevs

@cushon
Copy link
Contributor Author

cushon commented Nov 5, 2024

/approval This change improves annotation processing test coverage. I resolved a trivial merge conflict with JDK-8323684, which added the nameToAnnotation map. The modified test passes.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@cushon usage: /approval [<id>] (request|cancel) [<text>]

@cushon
Copy link
Contributor Author

cushon commented Nov 5, 2024

/approval request This change improves annotation processing test coverage. I resolved a trivial merge conflict with JDK-8323684, which added the nameToAnnotation map. The modified test passes.

@openjdk
Copy link

openjdk bot commented Nov 5, 2024

@cushon
8336942: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Nov 5, 2024
@GoeLin
Copy link
Member

GoeLin commented Nov 7, 2024

@cushon Please first get a review, then label for approval. Thanks.

@openjdk openjdk bot removed the approval label Nov 7, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 5, 2024

@cushon This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@cushon
Copy link
Contributor Author

cushon commented Dec 5, 2024

Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Assistance progressing this pull request towards integration is welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants