Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 #3159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 21, 2024

Hi all,

This pull request contains a backport of commit c7c7280f from the openjdk/jdk21u-dev repository.

The commit being backported was authored by SendaoYan on 21 Dec 2024 and was reviewed by Severin Gehwolf, Goetz Lindenmaier and Paul Hohensee.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8342145 needs maintainer approval
  • JDK-8341881 needs maintainer approval

Issues

  • JDK-8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 (Bug - P3 - Requested)
  • JDK-8342145: File libCreationTimeHelper.c compile fails on Alpine (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3159/head:pull/3159
$ git checkout pull/3159

Update a local copy of the PR:
$ git checkout pull/3159
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3159/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3159

View PR using the GUI difftool:
$ git pr show -t 3159

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3159.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 21, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 21, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c7c7280f6e25fb68950bad93aa20a96cfc9f35b3 8341881: [REDO] java/nio/file/attribute/BasicFileAttributeView/CreationTime.java#tmp fails on alinux3 Dec 21, 2024
@openjdk
Copy link

openjdk bot commented Dec 21, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 21, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 21, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 21, 2024

Webrevs

@sendaoYan
Copy link
Member Author

GHA report 1 failure:

  1. Job linux-x64 / build - Build / test at Get JTReg stage fails wget exited with exit code 4, seems like infrastructure issue or environmental issue, it's unrelated to this PR.

@sendaoYan
Copy link
Member Author

/approval request Clean backport to fix the test bug which cause test fails at some linux distro. Change has been verified locally, test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Dec 23, 2024

@sendaoYan
8341881: The approval request has been created successfully.
8342145: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant