Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309740: Expand timeout windows for tests in JDK-8179502 #3055

Open
wants to merge 1 commit into
base: pr/2747
Choose a base branch
from

Conversation

alexeybakhtin
Copy link

@alexeybakhtin alexeybakhtin commented Nov 18, 2024

Reviewed-by: xuelei, mbaesken

Follow-up clean test backport for JDK-8179502 (first in the series)


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8309740 needs maintainer approval

Integration blocker

 ⚠️ Dependency #2747 must be integrated first

Issue

  • JDK-8309740: Expand timeout windows for tests in JDK-8179502 (Bug - P3 - Requested)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3055/head:pull/3055
$ git checkout pull/3055

Update a local copy of the PR:
$ git checkout pull/3055
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3055

View PR using the GUI difftool:
$ git pr show -t 3055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3055.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 18, 2024

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into pr/2747 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 18, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 18, 2024
@mlbridge
Copy link

mlbridge bot commented Nov 18, 2024

Webrevs

@alexeybakhtin alexeybakhtin changed the title 8309740: Expand timeout windows for tests in JDK-8179502 Backport 5ca4cdd2caceba9dad8025e5a8851740a3961921 Nov 18, 2024
@openjdk openjdk bot changed the title Backport 5ca4cdd2caceba9dad8025e5a8851740a3961921 8309740: Expand timeout windows for tests in JDK-8179502 Nov 18, 2024
@openjdk
Copy link

openjdk bot commented Nov 18, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the approval label Nov 18, 2024
@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot removed the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Nov 20, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 20, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Dec 17, 2024

@alexeybakhtin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval backport clean rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant