8316882: Add NOT_INTERRUPTIBLE OpenOption and use it in ZipFS #22882
+135
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882.
Following discussion in nio-dev a while ago, I have opted to add a new
NOT_INTERRUPTIBLE
open option, supersedingFileChannelImpl#setUninterruptible
.Progress
Integration blocker
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22882/head:pull/22882
$ git checkout pull/22882
Update a local copy of the PR:
$ git checkout pull/22882
$ git pull https://git.openjdk.org/jdk.git pull/22882/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22882
View PR using the GUI difftool:
$ git pr show -t 22882
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22882.diff
Using Webrev
Link to Webrev Comment