Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316882: Add NOT_INTERRUPTIBLE OpenOption and use it in ZipFS #22882

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Technici4n
Copy link

@Technici4n Technici4n commented Dec 25, 2024

Here is a fix for https://bugs.openjdk.org/browse/JDK-8316882.

Following discussion in nio-dev a while ago, I have opted to add a new NOT_INTERRUPTIBLE open option, superseding FileChannelImpl#setUninterruptible.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion 25 to be approved (needs to be created)

Integration blocker

 ⚠️ Title mismatch between PR and JBS for issue JDK-8316882

Issue

  • JDK-8316882: (zipfs) ZipFileSystem closed by interrupt is unexpected (Bug - P4) ⚠️ Title mismatch between PR and JBS.

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22882/head:pull/22882
$ git checkout pull/22882

Update a local copy of the PR:
$ git checkout pull/22882
$ git pull https://git.openjdk.org/jdk.git pull/22882/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22882

View PR using the GUI difftool:
$ git pr show -t 22882

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22882.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 25, 2024

👋 Welcome back Technici4n! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 25, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Dec 25, 2024

@Technici4n The following labels will be automatically applied to this pull request:

  • core-libs
  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 26, 2024
@mlbridge
Copy link

mlbridge bot commented Dec 26, 2024

Webrevs

@AlanBateman
Copy link
Contributor

/csr

@openjdk openjdk bot added the csr Pull request needs approved CSR before integration label Dec 26, 2024
@openjdk
Copy link

openjdk bot commented Dec 26, 2024

@AlanBateman has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@Technici4n please create a CSR request for issue JDK-8316882 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@AlanBateman
Copy link
Contributor

The core issue is that FileChannel is an InterruptibleChannel. We've discussed several times on nio-dev about adding an open option to allow the channel be non-interruptible. None of these discussions concluded satisfactorily. If we do it then most of the work will be implications and FileChannel's specification. It looks like you've missed that part and focused on implementation changes. So I think this PR should be closed, please restart the discussion on nio-dev.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs [email protected] csr Pull request needs approved CSR before integration nio [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants