Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8344232: [PPC64] secondary_super_cache does not scale well: C1 and interpreter #22881

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Dec 25, 2024

PPC64 implementation of ead0116. I have implemented a couple of rotate instructions.
The first commit only implements lookup_secondary_supers_table_var and uses it in C2. The second commit makes the changes to use it in the interpreter, runtime and C1.
C1 part is refactored such that the same code as before this patch is generated when UseSecondarySupersTable is disabled. Some stubs are modified to provide one more temp register.

Performance difference can be observed when C2 is disabled (measured on Power10):

-XX:TieredStopAtLevel=1 -XX:-UseSecondarySupersTable:
SecondarySuperCacheHits.test  avgt   15  13.028 ± 0.005  ns/op
SecondarySuperCacheInterContention.test     avgt   15  417.746 ± 19.046  ns/op
SecondarySuperCacheInterContention.test:t1  avgt   15  417.852 ± 17.814  ns/op
SecondarySuperCacheInterContention.test:t2  avgt   15  417.641 ± 23.431  ns/op
SecondarySuperCacheIntraContention.test  avgt   15  340.995 ± 5.620  ns/op
-XX:TieredStopAtLevel=1 -XX:+UseSecondarySupersTable:
SecondarySuperCacheHits.test  avgt   15  14.539 ± 0.002  ns/op
SecondarySuperCacheInterContention.test     avgt   15  25.667 ± 0.576  ns/op
SecondarySuperCacheInterContention.test:t1  avgt   15  25.709 ± 0.655  ns/op
SecondarySuperCacheInterContention.test:t2  avgt   15  25.626 ± 0.820  ns/op
SecondarySuperCacheIntraContention.test  avgt   15  22.466 ± 1.554  ns/op

SecondarySuperCacheHits seems to be slightly slower, but SecondarySuperCacheInterContention and SecondarySuperCacheIntraContention are much faster (when C2 is disabled).


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8344232: [PPC64] secondary_super_cache does not scale well: C1 and interpreter (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22881/head:pull/22881
$ git checkout pull/22881

Update a local copy of the PR:
$ git checkout pull/22881
$ git pull https://git.openjdk.org/jdk.git pull/22881/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22881

View PR using the GUI difftool:
$ git pr show -t 22881

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22881.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 25, 2024

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 25, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 25, 2024
@openjdk
Copy link

openjdk bot commented Dec 25, 2024

@TheRealMDoerr The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Dec 25, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant