8344232: [PPC64] secondary_super_cache does not scale well: C1 and interpreter #22881
+304
−55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PPC64 implementation of ead0116. I have implemented a couple of rotate instructions.
The first commit only implements
lookup_secondary_supers_table_var
and uses it in C2. The second commit makes the changes to use it in the interpreter, runtime and C1.C1 part is refactored such that the same code as before this patch is generated when
UseSecondarySupersTable
is disabled. Some stubs are modified to provide one more temp register.Performance difference can be observed when C2 is disabled (measured on Power10):
SecondarySuperCacheHits
seems to be slightly slower, butSecondarySuperCacheInterContention
andSecondarySuperCacheIntraContention
are much faster (when C2 is disabled).Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22881/head:pull/22881
$ git checkout pull/22881
Update a local copy of the PR:
$ git checkout pull/22881
$ git pull https://git.openjdk.org/jdk.git pull/22881/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22881
View PR using the GUI difftool:
$ git pr show -t 22881
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22881.diff
Using Webrev
Link to Webrev Comment