Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8343882: BasicAnnoTests doesn't handle multiple annotations at the same position #22875

Open
wants to merge 1 commit into
base: jdk24
Choose a base branch
from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Dec 24, 2024

Hi all,

This pull request contains a backport of commit d562d3c7 from the openjdk/jdk repository. Test-fix only, no risk.

The commit being backported was authored by Liam Miller-Cushon on 20 Dec 2024 and was reviewed by Joe Darcy.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8343882: BasicAnnoTests doesn't handle multiple annotations at the same position (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22875/head:pull/22875
$ git checkout pull/22875

Update a local copy of the PR:
$ git checkout pull/22875
$ git pull https://git.openjdk.org/jdk.git pull/22875/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 22875

View PR using the GUI difftool:
$ git pr show -t 22875

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22875.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 24, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk24 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Dec 24, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d562d3c7a9e1e857c095ef908b0957b033972949 8343882: BasicAnnoTests doesn't handle multiple annotations at the same position Dec 24, 2024
@openjdk
Copy link

openjdk bot commented Dec 24, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Dec 24, 2024
@openjdk
Copy link

openjdk bot commented Dec 24, 2024

@sendaoYan The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

mlbridge bot commented Dec 24, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

1 participant