-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" #22870
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back stooke! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
@stooke To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
/label jcmd |
@stooke
|
/label hotspot serviceability |
@stooke The |
|
* java.compiler | ||
* java.management | ||
* jdk.internal.jvmstat/sun.jvmstat.monitor | ||
* @run testng/othervm -XX:+UsePerfData -XX:+UseZGC SystemMapTest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to add separate testcase for ZGC. It is expected that hotspot tests are usually executed to ensure that all functionality works with any GC.
If you want to add it to ensure that regression testcase is always executed even no ZGC is set then please
- add
* @requires vm.gc.Z
So testcase is not executed if non-ZGC GC (Parallel/Serial etc) is set explicitly. - Add
* @bug 8346717
- Add id like
* @test id=zgc
to make testcase name clearer.
This test fixes an issue with incomplete Windows threads not yet having a stack. A test for a null stack_base is added to guard against the potential null dereference. An additional test using ZGC is added to the jtreg SystemMapTest.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/22870/head:pull/22870
$ git checkout pull/22870
Update a local copy of the PR:
$ git checkout pull/22870
$ git pull https://git.openjdk.org/jdk.git pull/22870/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 22870
View PR using the GUI difftool:
$ git pr show -t 22870
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/22870.diff
Using Webrev
Link to Webrev Comment