Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[metOfficeDataHub] Initial contribution #15367

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

dag81
Copy link
Contributor

@dag81 dag81 commented Aug 3, 2023

[metOfficeDataHub] Initial code commit.

Addition of new Met Office Data Hub binding

-[metOfficeDataHub] Addition of new binding

Description

This is a new binding, which I have been using at home for more accurate temperature forecasts within the UK (I believe it does provide global data from the API definitions). Since moving to OH4 from OH3, I decided it had proven itself, over the last 10 months, so started doing the final pieces to raise this PR, so others can benefit from it as well.

The binding polls with careful consideration to the limitations of the met office API for free users (limited poll's per day), to retrieve forecast data, for each hour up to 24 hours, and for several days using daily forecasts. (For the duration of the systems runtime).

Testing

The core code base I have run at home for 10 months I think. Testing for this PR, has been checking the documented other channels that I do not use, and adjust as necessary comparing the raw values from the API in postman to those polled for the London example given.

@dag81 dag81 force-pushed the personal/bindings/metofficedatahubV4 branch 22 times, most recently from b368b77 to 7687840 Compare August 4, 2023 22:26
@dag81 dag81 marked this pull request as ready for review August 4, 2023 22:58
@dag81 dag81 requested a review from a team as a code owner August 4, 2023 22:58
@dag81 dag81 changed the title [metOfficeDataHub] Initial Commit for v4 [metOfficeDataHub] Initial Commit for new weather provider binding (UK MET Office) Aug 4, 2023
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/uk-met-office-weather-service-binding/148346/1

@holgerfriedrich holgerfriedrich added the new binding If someone has started to work on a binding. For a new binding PR. label Aug 4, 2023
@dag81 dag81 force-pushed the personal/bindings/metofficedatahubV4 branch 3 times, most recently from 9c43098 to bb3b226 Compare August 6, 2023 21:31
[metOfficeDataHub] Initial code commit.

Signed-off-by: David Goodyear <[email protected]>
[metOfficeDataHub] Initial code commit updates.

Signed-off-by: David Goodyear <[email protected]>
[metOfficeDataHub] Initial code commit updates.

Signed-off-by: David Goodyear <[email protected]>
[metOfficeDataHub] Initial code commit updates.

Signed-off-by: David Goodyear <[email protected]>
Updated to 4.2.X snapshot

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] PR feedback adjustments

Signed-off-by: David Goodyear <[email protected]>
[metOfficeDataHub] New API updates

Signed-off-by: David Goodyear <[email protected]>
[metOfficeDataHub] PR feedback adjustments

Signed-off-by: David Goodyear <[email protected]>
@dag81 dag81 force-pushed the personal/bindings/metofficedatahubV4 branch from e57de3d to 0527d4a Compare September 14, 2024 16:03
[metOfficeDataHub] Updated to 4.3

Signed-off-by: dag81 <[email protected]>
@dag81 dag81 force-pushed the personal/bindings/metofficedatahubV4 branch from 0527d4a to 9718c0a Compare September 14, 2024 16:11
@dag81
Copy link
Contributor Author

dag81 commented Sep 14, 2024

Hi @lsiepel, I'll change this one to draft while I go through all the renaming's, and bits done for link tap, and will convert back when ready to non draft. Re: LinkTap one I believe I've covered everything on that one so awaiting further bits on it when you have time.

@dag81 dag81 marked this pull request as draft September 14, 2024 16:24
[metOfficeDataHub] Channel name updates

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] Channel group name updates

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] HttpClient init updated

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] Readme new line corrections and header check

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] Exception handling cleanup

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] dispose handlers and doc updates.

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] charset read cleanup

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] device config caching

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] bridge cleanup

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] Cleanups

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] doc updates

Signed-off-by: dag81 <[email protected]>
@dag81 dag81 marked this pull request as ready for review September 17, 2024 22:37
[metOfficeDataHub] code cleanup

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] i18n pass 1

Signed-off-by: dag81 <[email protected]>
[metOfficeDataHub] Cleanups

Signed-off-by: dag81 <[email protected]>
@dag81 dag81 requested a review from lsiepel October 5, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants