Add custom CA support for buildkit/pro-builder #1229
+119
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are breaking changes to allow easier management of the images, and root/rootless settings. Signed-off-by: Alex Ellis (OpenFaaS Ltd) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are breaking changes to allow easier management of the images, and root/rootless settings.
Description
Add custom CA support for buildkit/pro-builder
Why is this needed?
For use with an in-cluster or self-signed registry such as Habor, or "distribution" aka Docker's OSS registry
Who is this for?
Requested by a customer
How Has This Been Tested?
Deployed a self-hosted registry with distribution, with a generated CA, and cert signed by the CA. The CA was given to buildkit, and
faas-cli publish --remote-builder.The image was published successfully with the rootless and root mode.
Types of changes
An overdue breaking change is made along with the custom CA support, in order to make it easier to update the images for root/rootless, and to avoid having to comment out blocks.
Users will now set
mode: [root|rootless]rather thanbuildkit.rootless: true/falseChecklist:
There will be an update to the Helm chart README and the docs to mention the new custom CA support.