Remove default ingress annotation from helm chart so that ingressClassName is settable in wrapped chart #1100
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the default ingress annotation that defaults to nginx. ingressClassName is the correct way to set the ingress.
Why is this needed?
Fixes #1000
When the chart is wrapped inside another it is not possible to unset the ingress annotation (see helm/helm/issues/9027). This means that if
ingress.ingressClassName
is set the deployment fails due to the annotation also being present.Who is this for?
We are StructureFlow.
How Has This Been Tested?
I've successfully deployed my local change to a local cluster with the ingress enabled and
ingressClassName: nginx
Types of changes
Checklist:
git commit -s