modified logging of 404s for pvc, configmaps and secrets (#618)

opendatahub-io · Oct 5, 2022 · 5e9f2bc · 5e9f2bc
1 parent 63747b6
commit 5e9f2bc
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/backend/src/routes/api/configmaps/index.ts b/backend/src/routes/api/configmaps/index.ts
@@ -21,7 +21,9 @@ module.exports = async (fastify: KubeFastifyInstance) => {
               e.message || res.message,
               e.code,
             );
-            fastify.log.error(`Configmap ${cmName} could not be read, ${error}`);
+            if (res.statusCode !== 404) {
+              fastify.log.error(`Configmap ${cmName} could not be read, ${error}`);
+            }
             throw error;
           });
       },

diff --git a/backend/src/routes/api/pvc/index.ts b/backend/src/routes/api/pvc/index.ts
@@ -20,9 +20,11 @@ module.exports = async (fastify: KubeFastifyInstance) => {
           );
           return pvcResponse.body;
         } catch (e) {
-          fastify.log.error(
-            `PVC ${pvcName} could not be read, ${e.response?.body?.message || e.message || e}`,
-          );
+          if (e.statusCode !== 404) {
+            fastify.log.error(
+              `PVC ${pvcName} could not be read, ${e.response?.body?.message || e.message || e}`,
+            );
+          }
           reply.send(e);
         }
       },

diff --git a/backend/src/routes/api/secrets/index.ts b/backend/src/routes/api/secrets/index.ts
@@ -20,11 +20,13 @@ module.exports = async (fastify: KubeFastifyInstance) => {
           );
           return secretResponse.body;
         } catch (e) {
-          fastify.log.error(
-            `Secret ${secretName} could not be read, ${
-              e.response?.body?.message || e.message || e
-            }`,
-          );
+          if (e.statusCode !== 404) {
+            fastify.log.error(
+              `Secret ${secretName} could not be read, ${
+                e.response?.body?.message || e.message || e
+              }`,
+            );
+          }
           reply.send(e);
         }
       },