-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: <carry>: correct typo in experiment model #10
UPSTREAM: <carry>: correct typo in experiment model #10
Conversation
the model name for epxeriment is ExperimentUUID, not ExperimentID Signed-off-by: Humair Khan <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
763dd96
into
opendatahub-io:master
A set of new images have been built to help with testing out this PR: |
An OCP cluster where you are logged in as cluster admin is required. The Data Science Pipelines team recommends testing this using the Data Science Pipelines Operator. Check here for more information on using the DSPO. To use and deploy a DSP stack with these images (assuming the DSPO is deployed), first save the following YAML to a file named apiVersion: datasciencepipelinesapplications.opendatahub.io/v1alpha1
kind: DataSciencePipelinesApplication
metadata:
name: pr-10
spec:
dspVersion: v2
apiServer:
image: "quay.io/opendatahub/ds-pipelines-api-server:pr-10"
argoDriverImage: "quay.io/opendatahub/ds-pipelines-driver:pr-10"
argoLauncherImage: "quay.io/opendatahub/ds-pipelines-launcher:pr-10"
persistenceAgent:
image: "quay.io/opendatahub/ds-pipelines-persistenceagent:pr-10"
scheduledWorkflow:
image: "quay.io/opendatahub/ds-pipelines-scheduledworkflow:pr-10"
mlmd:
deploy: true # Optional component
grpc:
image: "quay.io/opendatahub/ds-pipelines-metadata-grpc:pr-10"
envoy:
image: "quay.io/opendatahub/ds-pipelines-metadata-envoy:pr-10"
mlpipelineUI:
deploy: true # Optional component
image: "quay.io/opendatahub/ds-pipelines-frontend:pr-10"
objectStorage:
minio:
deploy: true
image: 'quay.io/opendatahub/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance' Then run the following: cd $(mktemp -d)
git clone [email protected]:opendatahub-io/data-science-pipelines.git
cd data-science-pipelines/
git fetch origin pull/10/head
git checkout -b pullrequest a11816b476d54e9ac7ce16afd91dc539b6bcb813
oc apply -f dspa.pr-10.yaml More instructions here on how to deploy and test a Data Science Pipelines Application. |
lgtm took the liberty of adding this context to the PR description
|
The ODH Dashboard UI needs this to be able to filter pipeline runs by experiment id/pipeline version id. Turns out that "experiment_id" doesn't work in KFP code even though it's listed as a filterable entity, due to a typo.
See for model name for experiment id :
https://github.com/kubeflow/pipelines/blob/d4c43f77bc38080506794377647ce5b1d9f18bdf/backend/src/apiserver/storage/run_store.go#L33