Add system-specific naming guidance #1708
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
commented
Dec 21, 2024
| the system name should be included in the instrument name using the pattern: | ||
| `{domain}.{client|server}.{system}.*.{property}` pattern. | ||
|
|
||
| For example, `db.client.cosmosdb.operation.request_charge` |
There was a problem hiding this comment.
the difference with signalr.server.connection.duration below makes me think if we should simplify it and do cosmosdb.client.operation.request_charge. What's the benefit of having db in front of it?
lmolkova
commented
Dec 21, 2024
|
|
||
| Examples: | ||
|
|
||
| - `db.cassandra.consistency_level` - Describes the consistency level property |
There was a problem hiding this comment.
Similar to https://github.com/open-telemetry/semantic-conventions/pull/1708/files#r1894523030
what's the benefit of having db in front of cassandra here? why not cassandra.consistency_level?
There was a problem hiding this comment.
Let's say we have some redis-specific attributes (and redis can be used as a DB and as a messaging system), would we define db.redis and messaging.redis ? probably not, it should be just redis.
This was referenced Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1494
Related:
azure_toaz.incloud.platformenum values #1698Documents:
{optional domain}.{system}pattern{domain}.client|server.{system}or{system}.client|serverpatternclientorserverMerge requirement checklist
[chore]