Update markdownlint #1706
Open
Update markdownlint #1706
+4
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
update-markdownlint
branch
from
c3b2cd8 to
a8b744b
Compare
This reverts commit 5a2af79.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #193
And closes #1703
I think the reason it was so slow before #193 is because it was running markdownlint in a loop over the files instead of passing the files into a single invocation of markdownlint
time make markdownlinton my machine reports:main: 8.8 secondsI also verified that the errors CLI was missing prior to #193 are not missed anymore.
I think this is an easier path forward (at least for me) compared to figuring out how to fix #1703 (see also open-telemetry/opentelemetry.io#5767)
cc @chalin