[vcs] add vcs.change.time_to_merge metric
#1685
Open
+81
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
The vcs.change.time_to_merge metric was removed in the previous PR following this discussion: #1383 (comment)
I thought that vcs.change.state attribute on the vcs.change.duration metric was sufficient to distinguish them, but it makes sense to have time_to_merge separate.
| - ref: vcs.ref.head.name | ||
| requirement_level: required | ||
| - ref: vcs.ref.head.revision | ||
| requirement_level: recommended |
There was a problem hiding this comment.
Should the revision attributes be opt-in instead of recommended due to the cardinality issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the
vcs.change.time_to_mergemetric from the GitHub Receiver. It didn't make as part of a previous pull request.Merge requirement checklist
[chore]