Add imports to instrumentations example in browser usage docs #5710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
Thanks, @gilisho! @open-telemetry/javascript-approvers, PTAL. |
pichlermarc
reviewed
Dec 5, 2024
| registerInstrumentations({ | ||
| instrumentations: [ | ||
| new DocumentLoadInstrumentation(), |
There was a problem hiding this comment.
adding this was not agreed on over at #4951, right?
Comment on lines
+263
to
+270
| const provider = new WebTracerProvider({ | ||
| spanProcessors: [new SimpleSpanProcessor(new ConsoleSpanExporter())], | ||
| }); | ||
|
|
||
| provider.register({ | ||
| // Changing default contextManager to use ZoneContextManager - supports asynchronous operations - optional | ||
| contextManager: new ZoneContextManager(), | ||
| }); |
There was a problem hiding this comment.
I think this is already explained above, should we duplicate the setup?
Comment on lines
+252
to
+258
| import { | ||
| ConsoleSpanExporter, | ||
| SimpleSpanProcessor, | ||
| } from '@opentelemetry/sdk-trace-base'; | ||
| import { WebTracerProvider } from '@opentelemetry/sdk-trace-web'; | ||
| import { DocumentLoadInstrumentation } from '@opentelemetry/instrumentation-document-load'; | ||
| import { ZoneContextManager } from '@opentelemetry/context-zone'; |
There was a problem hiding this comment.
If we don't do the duplicate setup then this can also be removed.
|
@gilisho can you take a look at the provided feedback? TY |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4951.
This PR adds missing imports in docs example. As a OTEL beginner, the instrumentation libraries that should be installed are not trivial. I've added these imports as a small improvement to the docs.