Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demonstration of new getList() method on the TextMapGetter #12581

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jamesmoessis
Copy link
Contributor

@jamesmoessis jamesmoessis commented Nov 7, 2024

Demonstrates proposed spec changes

Implements getList() in the Spring Web MVC instrumentation's JakartaHttpServletRequestGetter.

Implements a test to demonstrate the new W3CBaggagePropagator working with multiple baggage headers (using a locally published version of opentelemetry-api and opentelemetry-context, which contains the changes to the textmapgetter interface and baggage propagator).

The TextMapGetter operates on a Jakarta servlet HttpServletRequest, a very common interface used in many servers. This demonstrates that using getList() should work in many area / servers.

The build will obviously not pass because it's relying on local SNAPSHOT changes that aren't merged to main in opentelemetry-java

…ttpServletRequestGetter.

Implements a test to demonstrate the new W3CBaggagePropagator working with multiple baggage headers (using a locally published version of opentelemetry-api and opentelemetry-context).

The TextMapGetter operates on a Jakarta servlet HttpServletRequest, a very common interface used in many servers. This demonstrates that using getList() will work in many area / servers.
@github-actions github-actions bot added the test native This label can be applied to PRs to trigger them to run native tests label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test native This label can be applied to PRs to trigger them to run native tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant