Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CloudFoundry Resource Provider #1613

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KarstenSchnitter
Copy link

Description:

Adds a new module, that parses the environment variable VCAP_APPLICATION for properties required for the CloudFoundry resource convention. This variable is present for applications running on CloudFoundry and contains all necessary information in a JSON object.

This PR moves the code proposed in open-telemetry/opentelemetry-java-instrumentation#12861 to this repository

Existing Issue(s):

open-telemetry/opentelemetry-java-instrumentation#12861 and open-telemetry/opentelemetry-java-instrumentation#12862

Testing:

Unittests for the new functionality was added.

Documentation:

Please advise on necessary changes.

Outstanding items:

The could be a service name provider using the CloudFoundry application name, if no other source for the service name was found. I was unsure of the priority of such a provider, so I kept it for a later change.

Adds a new module, that parses the environment variable
VCAP_APPLICATION for properties required for the CloudFoundry
resource convention. This variable is present for applications
running on CloudFoundry and contains all necessary information
in a JSON object.

Signed-off-by: Karsten Schnitter <[email protected]>
@trask
Copy link
Member

trask commented Dec 17, 2024

can you add a README.md similar to other components, and add the component to https://github.com/open-telemetry/opentelemetry-java-contrib/blob/main/.github/component_owners.yml? do you know anyone else who would like to be a component owner for this? we really like to have (at least) two component owners from (at least) two different companies

Code owners for the CloudFoundry module are yet to be
determined.

Signed-off-by: Karsten Schnitter <[email protected]>
@KarstenSchnitter
Copy link
Author

@trask If I read the comment in the code_owners.yml correctly, this requires for me to be part of the OpenTelemetry Github organization, right? Currently, I am not a member. I just started with contributions to OpenTelemetry, e.g., open-telemetry/semantic-conventions#624. I do not want to disregard the OpenTelemetry community guidelines by adding myself to the code owners. How do you suggest to proceed?

I have added a draft version of the README.md without code owner references to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants