Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust otel_metric_producer callbacks #756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

javiergarea
Copy link

Updated callback typespec to match actual callback module invocations.

@javiergarea javiergarea requested a review from a team July 15, 2024 08:52
Copy link

linux-foundation-easycla bot commented Jul 15, 2024

CLA Signed


The committers listed above are authorized under a signed CLA.

Copy link
Member

@tsloughter tsloughter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tsloughter
Copy link
Member

Can you sign the CLA?

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.19%. Comparing base (d1e392b) to head (667762f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #756   +/-   ##
=======================================
  Coverage   73.19%   73.19%           
=======================================
  Files          64       64           
  Lines        1940     1940           
=======================================
  Hits         1420     1420           
  Misses        520      520           
Flag Coverage Δ
api 69.90% <ø> (ø)
elixir 17.32% <ø> (ø)
erlang 74.51% <ø> (ø)
exporter 73.06% <ø> (ø)
sdk 77.30% <ø> (ø)
zipkin 54.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javiergarea
Copy link
Author

Can you sign the CLA?

Sure!

@javiergarea javiergarea requested a review from tsloughter July 15, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants