-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update otel bot permissions #2239
base: main
Are you sure you want to change the base?
Conversation
FYI, I've already assigned this scope to the OpenTelemetry bot. If we end up not accepting this PR, we should revert the scope. |
FYI, I've reverted the |
We (OTel JS SIG) would actually appreciate having the It would allow us to update descriptions for PRs opened by @opentelemetrybot. Recently we added a workflow to automatically create release PRs, the workflow can't edit the description of its own PR without See open-telemetry/opentelemetry-js#4849, https://github.com/open-telemetry/opentelemetry-js/actions/runs/10195580438/job/28204768571#step:8:389 |
I think it's ok to give @opentelemetrybot the from https://docs.github.com/en/apps/oauth-apps/building-oauth-apps/scopes-for-oauth-apps#available-scopes,
and @opentelemetrybot doesn't have any special read privileges to the @open-telemetry org (it is just a normal org member). @pichlermarc can you open a repository maintenance issue in this repo and we can see if there's agreement from others? |
Sure thing - opened #2277 just now. Thanks 🙌 |
@jack-berg can you re-revert it now that we need it for #2277? (and then also we can re-test without triage permission in the website repo) |
done |
@open-telemetry/technical-committee @open-telemetry/governance-committee please review this PR, we want to move forward with it again, thanks |
I am confused about what is being added after reverts and re-reverts :-) @svrnm can you please update the PR description to clarify the change, why and what is being changed? |
I am confused as well, but if I understand it correctly the JS SIG wants to have the permissions I listed here, so the PR content should be good? Trying to update the description to reflect that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am confused as well, but if I understand it correctly the JS SIG wants to have the permissions I listed here, so the PR content should be good?
Yes that is correct - the content of this PR now accurately reflects what the current permissions are (and they align with what the JS SIG needs). 🙂
@open-telemetry/technical-committee @open-telemetry/governance-committee the PR description is updated and ready for review, thanks! |
Related to #2234Updated: This is required for #2277, needed by @open-telemetry/javascript-maintainers: "read:org permission would allow us to update descriptions for PRs opened by @opentelemetrybot. Recently we added a workflow to automatically create release PRs, but the workflow can't edit the description of its own PR without read:org."