Compile with shared=False as default
#112
Conversation
There was a problem hiding this comment.
This led me to implement #113, because I wanted to check out the licences of our dependencies before approving the PR. And it turns out that openssl is GPL licensed, so we can't link it statically into our release bundles. xz_utils contains optional LGPL-licensed features, so we should probably be careful about that too. I suggest you set the shared option for both of these packages to True irrespective of Cosim's own setting.
There was a problem hiding this comment.
After your comment on #113, I looked more closely at this, and it looks like neither openssl nor xz_utils pose problems, licence-wise. The former is covered by the OpenSSL or Apache licences, depending on version, and the library component of the latter is in the public domain or covered by the 0BSD licence, also depending on version. Sorry for the confusion.
In other words: LGTM!
Fixes #102.
I recently ran into one of the issues described in #102, where both Cosim and the FMU depend on a the same shared library but in different, incompatible versions.