-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat2/josep #570
base: main
Are you sure you want to change the base?
Feat2/josep #570
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks
Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.
Issue Reference
In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide.
This check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.
Conventional Commit PR Title
In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:
- docs: correct typo in README
- feat: implement dark mode"
- fix: correct remove button behavior
Linting Errors
- Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
- No subject found
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @josep-b,
Thank you for your contribution! β¨
There are several things here:
-
You have failed checks that you need to address before we can review your PR. Please fix each of them until all checks pass.
-
You need to complete your PR template. We can't review your PR if it's not completed.
-
You have three issues open. Please close two of them and keep the one you want to keep.
Let me know once you've fixed them and if you have questions or need help.
Thank you. π
Description
What type of PR is this? (check all applicable)
Related Issues
Contributors Checklist
I've read through the Getting Started section
Have you run
npm run contributors:generate
to generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?