OpTestKernelTest: Add support for automated boot bisection v2.0 #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdhaleegit
force-pushed
the
bootbisect-v2
branch
from
5ba846f
to
32b4cbb
Compare
This code is modifed and develped on top of the previous code (2f103 : OpTestKernelTest: Git bisect automation..) With version 2.0 these are the new changes added: 1. Added support to handle nested bisection loop, which was not working with previous code 2. Modified code to work for end to end CI server 3. Better handle all cases of good flow and bad flow 4. Add json store of good boot commit for good run 5. Fix the previous code blocker to properly manage the console thread TODO: Add boot json generation after bisection with bad commit Email format for boot bug report Signed-off-by: Abdul Haleem <[email protected]>
abdhaleegit
force-pushed
the
bootbisect-v2
branch
from
32b4cbb
to
75ab46b
Compare
PraveenPenguin
requested changes
Oct 5, 2024
| @@ -109,8 +106,8 @@ def is_url(path): | |||
| log.info("Upstream kernel commit-time: %s", tcommit) | |||
| log.debug("Compile the upstream kernel") | |||
| try: | |||
| cpu= self.con.run_command("lscpu | grep '^CPU(s):' | awk '{print $2}'") | |||
| err=self.con.run_command("make -j {} -s vmlinux".format(cpu[-1]), timeout=self.host_cmd_timeout) | |||
| cpu = int(self.con.run_command("lscpu --online -e|wc -l")[-1]) | |||
There was a problem hiding this comment.
Please push this a utility function that can be reused in other places like example Gcov , kernel upstream build test
| self.con.run_command("make modules_install") | ||
| self.con.run_command("make install") | ||
| cpu = int(self.con.run_command("lscpu --online -e|wc -l")[-1]) | ||
| self.con.run_command("make -j {} -s".format(cpu), timeout=60000) |
There was a problem hiding this comment.
Let us use optest command line variable as may in some system it require more time
| kernel_version_output = self.con.run_command("uname -r")[-1] | ||
| log.info("Installed upstream kernel version: %s", kernel_version_output) | ||
| if kernel_version_output[-1] == base_version[-1]: | ||
| log.error("Kexec failed, booted back to base kernel !") |
There was a problem hiding this comment.
Is failing a test, not an appropriate call here?
| @@ -266,7 +271,7 @@ def runTest(self): | |||
| self.con.run_command("cd {}".format(self.home)) | |||
| if not self.branch: | |||
| self.branch='master' | |||
| self.con.run_command("git clone --depth 1 -b {} {} linux".format( self.branch, self.repo),timeout=3000) | |||
| self.con.run_command("git clone -b {} {} linux".format( self.branch, self.repo),timeout=3000) | |||
There was a problem hiding this comment.
Lets have these changes in other commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is modifed and develped on top of the previous code (2f103 : OpTestKernelTest: Git bisect automation..)
With version 2.0 these are the new changes added:
TODO:
Add boot json generation after bisection with bad commit
Email format for boot bug report