Changing the kernel package name for sles distro kernel_src build #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PraveenPenguin
requested changes
Aug 20, 2024
common/OpTestUtil.py
Outdated
| @@ -2316,7 +2316,7 @@ def get_distro_src(self, package, dest_path, build_option=None, pack_dir=None): | |||
|
|
|||
| elif self.distro_name() == 'sles': | |||
| host.host_run_command("zypper install -y rpm-build") | |||
| s_cmd = f"zypper -n source-install {package};cd /usr/src/packages/SOURCES/;./mkspec;cp {package}.spec ../SPECS/" | |||
| s_cmd = f"zypper -n source-install kernel-source;cd /usr/src/packages/SOURCES/;./mkspec;cp {package}.spec ../SPECS/" | |||
There was a problem hiding this comment.
As this is utility, have this is a generic, overwrite the value from the caller
There was a problem hiding this comment.
@Naresh-ibm we need the package value (kernel-default) in rest of the places as is.
And kernel-source is needed at the time of installation itself. So just changed this place only and rest it will be kernel-default which is needed
Sles uses the different package name for kernel src. earlier we used kernel-default. But the package names are like kernel-source. Again fot build it uses kernel-default only but for install it uses kernel-source. So just changing it to kernel-source. Signed-off-by: Naresh Bannoth <[email protected]>
Naresh-ibm
force-pushed
the
sles_src_build
branch
from
36fa0b5
to
d2b4cdf
Compare
PraveenPenguin
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sles uses the different package name for kernel src. earlier we used kernel-default. But the package names are like kernel-source. Again fot build it uses kernel-default only but for install it uses kernel-source. So just changing it to kernel-source.