Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix ] add batch processing when saving frames in demo #224

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rlleshi
Copy link

@rlleshi rlleshi commented Jul 14, 2022

Currently, array_to_images converts all the array frames to images in one go (so loads them all in memory and then converts them). It might be better to convert them into batches for the following reason:

The np.array-loading of images for example here in the demo means that we load the entire images twice into memory. This means that it can potentially oom if one is processing too many images or if the images are of high resolution.

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Base: 84.77% // Head: 84.77% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ac40093) compared to base (fe9cc4c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #224   +/-   ##
=======================================
  Coverage   84.77%   84.77%           
=======================================
  Files         199      199           
  Lines       17558    17565    +7     
=======================================
+ Hits        14884    14891    +7     
  Misses       2674     2674           
Flag Coverage Δ
unittests 84.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmhuman3d/utils/ffmpeg_utils.py 90.57% <ø> (ø)
mmhuman3d/utils/demo_utils.py 84.44% <100.00%> (+0.35%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@ttxskk ttxskk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rlleshi
Thanks for your contribution, nice PR!
Could you please add a unit test for the added function? You can take this as an example.

@ttxskk
Copy link
Collaborator

ttxskk commented Aug 17, 2022

Many thanks for the update. Currently, there are conflicts that need to be manually resolved.

@rlleshi
Copy link
Author

rlleshi commented Aug 17, 2022

@ttxskk you would like me to resolve them or is it something you need to do?

@ttxskk
Copy link
Collaborator

ttxskk commented Aug 19, 2022

@ttxskk you would like me to resolve them or is it something you need to do?

I hope you can resolve them directly.

@rlleshi
Copy link
Author

rlleshi commented Sep 9, 2022

@ttxskk fixed the conflict

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants