libtcmu: allow multiple daemons co-exist #519
Conversation
libtcmu.c
Outdated
| @@ -432,8 +434,8 @@ static int add_device(struct tcmulib_context *ctx, char *dev_name, | |||
|
|
|||
| dev->handler = find_handler(ctx, dev->cfgstring); | |||
| if (!dev->handler) { | |||
| tcmu_err("could not find handler for %s\n", dev->dev_name); | |||
| goto err_free; | |||
| tcmu_dbg("could not find handler for %s\n", dev->dev_name); | |||
There was a problem hiding this comment.
should this be a warning tcmu_warn () ?
For tcmu-runner case, it is helpful to have this msg at logs with non-debug log levels too.
There was a problem hiding this comment.
Yeah, that makes sense to me, thanks.
libtcmu.c
Outdated
| err_nohandler: | ||
| free(dev); | ||
|
|
||
| return 1; |
There was a problem hiding this comment.
In general, It makes more sense to return -1/1 for all those str***() function errors, and return ENOENT for nohandler case.
As we support libtcmu again users could want to run several daemons at the same time. So don't fail the device addition via netlink reply when can't find a handler in ctx to handle the device. This just means the device addition event is not for this ctx so give other daemons a chance to try. Signed-off-by: Yaowei Bai <[email protected]>
baihuahua
force-pushed
the
support-many-daemons
branch
from
5853939
to
f38a12c
Compare
|
Updated, please review. Thanks. @pkalever @mikechristie |
|
Hey Mike, what do you think about this? @mikechristie |
|
I am on PTO from Jan 28 - Feb 8. I am going to try and get to this next week while on vacation. |
|
This looks fine to me. |
|
Thanks @bgly .Mike, what do you think about this? @mikechristie |
|
targetcli hangs if the added device subtype is not found by any daemon. Restarting tcmu-runner solves the problem because it resets the netlink interface, but this is not a good solution. Also consider that a custom daemon might crash or be killed during the handling of TCMU_CMD_ADDED_DEVICE, which would also cause targetcli to hang. |
As we support libtcmu again users could want to run several
daemons at the same time. So don't fail the device addition
via netlink reply when can't find a handler in ctx to handle
the device. This just means the device addition event is not
for THIS ctx so give other daemons a chance to try.
This fix is for issue #516 .
Signed-off-by: Yaowei Bai [email protected]