Add media change support v2 #435
Conversation
|
Any ETA on this @mikechristie |
|
Ah sorry. I didn't see you update the targetcli patch. I will test it all again today. |
|
sounds good, thanks mike! |
|
Just a FYI, I am still working on this. It will get done this week. |
|
Did you ever send the kernel patch to update the uio name when writing to the dev_control control file? If not, I attached a patch here: |
It doesn't look like the dbus handler registration is used anymore. We are not using the check_config callout anymore and the registration code did not seem to fully register a handler for cmd processing, so drop it. Signed-off-by: Mike Christie <[email protected]>
Make tcmu_set_control a macro so it can be reused in the next patch for setting a string. Signed-off-by: Mike Christie <[email protected]>
Move the UA code so it can be called from other files. Signed-off-by: Mike Christie <[email protected]>
This will be used in the next patches so targetcli can pass in the tcmu name to dbus commands. Signed-off-by: Mike Christie <[email protected]>
This will be used in the next patch to set dev_config Signed-off-by: Mike Christie <[email protected]>
Signed-off-by: Mike Christie <[email protected]>
This patch series will add media change that is triggered via targetcli without involving the kernel Based on patches my Bryant G. Ly. Signed-off-by: Bryant G. Ly <[email protected]> Signed-off-by: Mike Christie <[email protected]>
In debug mode log failed commands. Signed-off-by: Mike Christie <[email protected]>
mikechristie
force-pushed
the
mediachanged
branch
from
7617877
to
bb29f64
Compare
|
Repushed branch. It should work with the targecli patch attached to your PR and to the kernel patch above. It is pretty much the same as before, but with the media -> medium rename, some error handler fixes so nicer strings are returned on failure, and I added a check so only handlers that report they support the op get called. |
|
Looks good to me @mikechristie |
| reason = "Handler does not support medium changes."; | ||
| goto exit; | ||
| } | ||
|
|
There was a problem hiding this comment.
Shoot. Giving myself a review comment.
We need to add lock or refcounting around parts of this to prevent the race where this is running along side a device removal.
|
bump? |
Patches to add media change support based on @bgly's PR
#411