Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to align CTS and Spec for Memory #2177

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improvements to align CTS and Spec for Memory #2177

wants to merge 1 commit into from

Conversation

martygrant
Copy link
Contributor

  • Add test for expecting UR_RESULT_ERROR_INVALID_NULL/HOST_POINTER for urMemImageCreate and urMemBufferCreate
  • Add more checks for UR_RESULT_ERROR_INVALID_IMAGE_FORMAT_DESCRIPTOR for urMemImageCreate
  • Added missing error condition to spec for urMemImageCreate - UR_STRUCTURE_TYPE_IMAGE_DESC != pImageDesc->stype
  • Add tests for expecting UR_RESULT_ERROR_INVALID_NULL_HANDLE/POINTER for urMemBuffer/ImageCreateWithNativeHandle
  • Remove skip for urMemImageCreateWithNativeHandle - buffer was invalid, creating it in the test fixture definition now
  • Update image format used in urMemImageText fixture as it was invalid and would cause previously skipped tests to fail (they now pass)
  • Fix DDI table entry for urMemImageCreateWithNativeHandle for OpenCL
  • Add test for calling urMemBufferPartition with different ur_mem_flag_t flags
  • Add missing UR_MEM_INFO_REFERENCE_COUNT to spec for urMemGetInfo. Added a test for this and checking ref count is updated in urMemRetain/Release

@martygrant martygrant requested review from a team as code owners October 7, 2024 11:10
@martygrant martygrant requested a review from hdelan October 7, 2024 11:10
@github-actions github-actions bot added loader Loader related feature/bug conformance Conformance test suite issues. specification Changes or additions to the specification level-zero L0 adapter specific issues cuda CUDA adapter specific issues hip HIP adapter specific issues labels Oct 7, 2024
@martygrant martygrant mentioned this pull request Oct 7, 2024
Draft
@martygrant
Improvements to align CTS and Spec for Memory:
4019c6b 
	- Add test for expecting UR_RESULT_ERROR_INVALID_NULL/HOST_POINTER for urMemImageCreate and urMemBufferCreate
	- Add more checks for UR_RESULT_ERROR_INVALID_IMAGE_FORMAT_DESCRIPTOR for urMemImageCreate
	- Added missing error condition to spec for urMemImageCreate - UR_STRUCTURE_TYPE_IMAGE_DESC != pImageDesc->stype
	- Add tests for expecting UR_RESULT_ERROR_INVALID_NULL_HANDLE/POINTER for urMemBuffer/ImageCreateWithNativeHandle
	- Remove skip for urMemImageCreateWithNativeHandle - buffer was invalid, creating it in the test fixture definition now
	- Update image format used in urMemImageText fixture as it was invalid and would cause previously skipped tests to fail (they now pass)
	- Fix DDI table entry for urMemImageCreateWithNativeHandle for OpenCL
	- Add test for calling urMemBufferPartition with different ur_mem_flag_t flags
	- Add missing UR_MEM_INFO_REFERENCE_COUNT to spec for urMemGetInfo. Added a test for this and checking ref count is updated in urMemRetain/Release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RossBrunton RossBrunton RossBrunton approved these changes

@hdelan hdelan Awaiting requested review from hdelan hdelan is a code owner automatically assigned from oneapi-src/unified-runtime-hip-write

Assignees
No one assigned
Labels
conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug specification Changes or additions to the specification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martygrant @RossBrunton