Merge changes from multi device compile extension into core spec.

[aarongreig]

We originally changed this interface a bit from PI: currently these entry points take a context which represents your list of devices. This turned out to cause issues for the level zero adapter so the extension was created to effectively revert back to the PI/CL style interface. This PR reverts the core interface back to PI style, everything takes an explicit device list instead of a context.

LLVM testing intel/llvm#12536

[codecov-commenter]

Codecov Report

Attention: 93 lines in your changes are missing coverage. Please review.

Comparison is base (b66cf9b) 15.46% compared to head (46722a5) 15.37%.
Report is 25 commits behind head on main.

Files	Patch %	Lines
source/loader/ur_ldrddi.cpp	0.00%	18 Missing ⚠️
source/loader/layers/validation/ur_valddi.cpp	0.00%	17 Missing ⚠️
test/conformance/program/urProgramLink.cpp	0.00%	17 Missing ⚠️
test/conformance/program/urProgramBuild.cpp	0.00%	9 Missing ⚠️
test/conformance/program/urProgramCompile.cpp	0.00%	9 Missing ⚠️
source/loader/layers/tracing/ur_trcddi.cpp	0.00%	7 Missing ⚠️
source/loader/ur_libapi.cpp	0.00%	4 Missing ⚠️
source/adapters/null/ur_nullddi.cpp	0.00%	3 Missing ⚠️
test/conformance/testing/include/uur/fixtures.h	0.00%	3 Missing ⚠️
test/conformance/kernel/urKernelCreate.cpp	0.00%	1 Missing ⚠️
... and 5 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1195      +/-   ##
==========================================
- Coverage   15.46%   15.37%   -0.10%     
==========================================
  Files         238      238              
  Lines       33883    33689     -194     
  Branches     3747     3714      -33     
==========================================
- Hits         5239     5178      -61     
+ Misses      28593    28461     -132     
+ Partials       51       50       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JackAKirk]

Can you add a description for this PR please?
I've looked at e.g. #912 and I think I understand that you want to change the interface so it is more flexible and is associating a particular binary with particular devices.

From my experience of CUDA/HIP Outside of MPI which is a completely different mechanism, I am not aware of any multi-device compilation process where the output of a single compilation is to produce different binaries for each of the device. I don't know of any CUDA/HIP documentation on how to deal with this use case.

Therefore, if you could clarify things like:

• What is the initial motivation for this feature (e.g. give an specific example of a use case that requires such an interface)
• Which backends is this useful for?
• Are there any particular considerations for specific backend?

I think that would help with review, allowing me to make a deeper investigation of any potential backend specific issues. Otherwise the only thing I can check is that it doesn't break the standard case where you are just outputting a single binary for all devices.

[aarongreig]

The extension was a last minute fix for issues level zero ended up having with a redesign, this basically fully reverts the redesign by merging the extension.

[JackAKirk]

The extension was a last minute fix for issues level zero ended up having with a redesign, this basically fully reverts the redesign by merging the extension.

Is there an accompanying PR in intel/llvm to change this line https://github.com/intel/llvm/blob/f4b4a84b653fb77a9db834d4f588ac347681ea30/sycl/plugins/unified_runtime/pi2ur.hpp#L2068
etc?
It would be nice to check such a PR passes intel/llvm CI.

[aarongreig]

..not doing a good job of following my own project's process here

[fabiomestre]

Looks good to me. Also makes things cleaner in OpenCL 👍

[nrspruit]

LGTM for level zero, cleans up things greatly as long as we are not breaking customers that were expecting this behavior.

[PietroGhg]

Native CPU LGTM, thank you

[JackAKirk]

LGTM