Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en.xml #155

Open
wants to merge 1 commit into
base: android-7.1
Choose a base branch
from
Open

Update en.xml #155

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented May 12, 2017

I discovered several inconsistencies in the wording of "SD Card". All text strings state "SD Card" - with a space between "SD" & "Card" and a capital "C", except 3. I corrected these 3 strings to "SD Card" (with a space and capital "C") to be consistent with all other strings. I would be happy to see them corrected in the upcoming patch/release.

I discovered several inconsistencies in the wording of "SD Card". All text strings state "SD Card" - with a space between "SD" & "Card" and a capital "C", except 3. I corrected these 3 strings to "SD Card" (with a space and capital "C") to be consistent with all other strings. I would be happy to see them corrected in the upcoming patch/release.
@DevUt
Copy link
Contributor

DevUt commented May 24, 2017

We appreciate your thought to contribute to TWRP but please use https://gerrit.omnirom.org/#/admin/projects/android_bootable_recovery to submit your changes to us

@ghost
Copy link
Author

ghost commented May 24, 2017

Hi DevUt,
thanks for getting in touch with me. I'm sorry saying it, but I must admit that I'm propably to "dumb" to submit the change in Gerrit. I've tried it, but I'm at the end of my knowledge. It is possible for you, to submit my suggested change this one time for me? Many many thanks in advance.

@DevUt
Copy link
Contributor

DevUt commented May 24, 2017

@ghost
Copy link
Author

ghost commented May 25, 2017

Hi DevUt,
thank you very much for adding the change to Gerrit for me :-). I just saw, that line 29 can be ignored, since it just a code comment line "<!--This a rarely used [...]". I removed the one change in the comment line and saved it in Gerrit, as the comment line is just a comment line :-), the other ones are good - fortunately this was very easy for me, after the change was already there in Gerrit :-). Thanks again for doing this for me - wish you a good weekend ;-)

@ghost
Copy link
Author

ghost commented Jul 12, 2017

Hi DevUt,
are there any news when the changes will be merged to be included in the next TWRP release?

https://gerrit.omnirom.org/#/c/23648/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant