Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Set() able to re-write nil type with map or array #24

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Make Set() able to re-write nil type with map or array #24

wants to merge 4 commits into from

Conversation

latitov
Copy link

@latitov latitov commented May 28, 2021

No description provided.

olebedev
olebedev requested changes May 30, 2021
View reviewed changes
Copy link
Owner

@olebedev olebedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The intention looks good to me. Can you please add a test of this new addition?

@latitov
Copy link
Author

latitov commented May 31, 2021

Okay, in coming days I will do, thanks.

@molproduktooo molproduktooo mentioned this pull request Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olebedev olebedev olebedev requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@latitov @olebedev