Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates homebrew formula #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lbeckman314
Copy link
Member

@lbeckman314 lbeckman314 commented Oct 31, 2023

⚠️ Note: This PR shows the required steps for updating the Homebrew formula. It currently references 0.11.0-rc.1 of Funnel and will need to be updated for the final 0.11.0 release before merging.

Overview

This PR updates the Homebrew formula to successfully install funnel via brew install funnel

Current Behavior ❌

Installing Funnel via Homebrew fails:

brew install funnel
==> Downloading https://formulae.brew.sh/api/formula.jws.json
################################################################################################## 100.0%
==> Downloading https://formulae.brew.sh/api/cask.jws.json
################################################################################################## 100.0%
Error: funnel: wrong number of arguments (given 1, expected 0)

New Behavior ✅

Testing the new formula file:

➜ brew install --build-from-source ./build/release/funnel.rb

Error: Failed to load cask: ./build/release/funnel.rb
Cask 'funnel' is unreadable: wrong constant name #<Class:0x0000000111385b50>
Warning: Treating ./build/release/funnel.rb as a formula.
==> Fetching funnel
==> Downloading https://github.com/ohsu-comp-bio/funnel/releases/download/0.11.0-rc.1/funnel-darwin-arm64-0.11.0-rc.1.tar.gz
...
🍺  /opt/homebrew/Cellar/funnel/0.11.0-rc.1: 4 files, 81.4MB, built in 9 seconds
==> Running `brew cleanup funnel`...
Disable this behaviour by setting HOMEBREW_NO_INSTALL_CLEANUP.
Hide these hints with HOMEBREW_NO_ENV_HINTS (see `man brew`).

Verifying download:

➜  /opt/homebrew/Cellar/funnel/0.11.0-rc.1/bin/funnel
Usage:
  funnel [command]

Available Commands:
  aws         Development utilities for creating funnel resources on AWS
  completion  Generate shell completion code
  dashboard   Start a Funnel dashboard in your terminal.
  examples    Print example task messages.
  gce
  help        Help about any command
  node        Funnel node subcommands.
  run         Run a task.
  server      Funnel server commands.
  storage     Access storage via Funnel's client libraries.
  task        Make API calls to a TES server.
  version
  worker      Funnel worker commands.

Flags:
  -h, --help   help for funnel

Use "funnel [command] --help" for more information about a command.

@lbeckman314 lbeckman314 marked this pull request as draft October 31, 2023 01:14
@lbeckman314
Copy link
Member Author

lbeckman314 commented Oct 31, 2023

Possible issue with the current formula: goreleaser/goreleaser#2591

Removing the bottle :unneeded line resolves the issue and allows brew install --build-from-source ./Formula/funnel.rb to install Funnel successfully with the existing Formula.

@lbeckman314 lbeckman314 marked this pull request as ready for review December 7, 2023 23:19
@lbeckman314 lbeckman314 self-assigned this Dec 7, 2023
@lbeckman314 lbeckman314 added the bug label Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant