load-frontend-fits-file-uri

[burnout87]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 62.40%. Comparing base (6e98f24) to head (9faf4bd).
Report is 9 commits behind head on master.

Files with missing lines	Patch %	Lines
cdci_data_analysis/flask_app/app.py	95.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #708      +/-   ##
==========================================
+ Coverage   62.33%   62.40%   +0.07%     
==========================================
  Files          50       50              
  Lines        8982     9002      +20     
==========================================
+ Hits         5599     5618      +19     
- Misses       3383     3384       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dsavchenko]

So the difference from the existing file upload endpoint is that this basically acts as middleware that appends required headers, but doesn't persist the file itself?

[dsavchenko]

Well, this approach will work as long as dispatcher and frontend have the same Origin (i.e. served on the same domain. Which is the case in our deployments, the dispatcher is proxied through frontend's webserver at /dispatch-data endpoint.)
So there is no need to set any additional header.

[francoismg]

Well, this approach will work as long as dispatcher and frontend have the same Origin (i.e. served on the same domain. Which is the case in our deployments, the dispatcher is proxied through frontend's webserver at /dispatch-data endpoint.) So there is no need to set any additional header.

Yes and if it were to change it would be easy to check the origin against a list of authorized origins and set the origin in the header response if there's a match