Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep dataserver query status messages #554

Merged
merged 5 commits into from
Jul 14, 2023
Merged

keep dataserver query status messages #554

merged 5 commits into from
Jul 14, 2023

Conversation

dsavchenko
Copy link
Member

No description provided.

volodymyrss
volodymyrss previously approved these changes Jul 13, 2023
burnout87
burnout87 previously approved these changes Jul 13, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #554 (54638d8) into master (cb5b4f5) will not change coverage.
The diff coverage is 90.00%.

@@           Coverage Diff           @@
##           master     #554   +/-   ##
=======================================
  Coverage   62.10%   62.10%           
=======================================
  Files          45       45           
  Lines        7658     7658           
=======================================
  Hits         4756     4756           
  Misses       2902     2902           
Impacted Files Coverage Δ
cdci_data_analysis/analysis/instrument.py 81.41% <ø> (ø)
cdci_data_analysis/analysis/queries.py 61.35% <90.00%> (ø)

@dsavchenko
Copy link
Member Author

One test is failing, but it fails even with master branch. I will investigate

@dsavchenko dsavchenko dismissed stale reviews from burnout87 and volodymyrss via 25dc3a1 July 14, 2023 10:09
@dsavchenko
Copy link
Member Author

Small fix unrelated to the PR purpose: run_asynch is also valid non-parameter argument.

@volodymyrss volodymyrss merged commit bcae281 into master Jul 14, 2023
16 checks passed
@dsavchenko dsavchenko deleted the keep-status branch July 15, 2023 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants