Skip to content

Commit

Permalink
Check help files only for packages building binaries (#1629)
Browse files Browse the repository at this point in the history
  • Loading branch information
@gpetiot
gpetiot authored Mar 31, 2021
1 parent 03a2946 commit 3697f0f
Showing 1 changed file with 12 additions and 6 deletions.
18 changes: 12 additions & 6 deletions dune
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,28 @@
(:standard -noassert))))

(rule
(with-stdout-to
ocamlformat-help.actual
(run ocamlformat --help=plain)))
(action
(with-stdout-to
ocamlformat-help.actual
(run %{bin:ocamlformat} --help=plain)))
(package ocamlformat))

(rule
(alias runtest)
(package ocamlformat)
(action
(diff ocamlformat-help.txt ocamlformat-help.actual)))

(rule
(with-stdout-to
ocamlformat-rpc-help.actual
(run ocamlformat-rpc --help=plain)))
(action
(with-stdout-to
ocamlformat-rpc-help.actual
(run %{bin:ocamlformat-rpc} --help=plain)))
(package ocamlformat-rpc))

(rule
(alias runtest)
(package ocamlformat-rpc)
(action
(diff ocamlformat-rpc-help.txt ocamlformat-rpc-help.actual)))

Expand Down

3 comments on commit 3697f0f

@olafhering
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Given that this is like the fifth 0.18.0 tag today, how about a 0.18.6 in case there are more release attempts for 0.18?

@gpetiot
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, sorry about the inconvenience! I would like to keep these tags for possible future minor releases, master will be in an unstable state as long as the 0.18.0 release is sitll marked as a pre-release, i.e. as long as the opam CI is unhappy.
This 0.18.0 release is particuliarly painful on the opam CI side as there are now 3 different ocamlformat packages, but I'm trying to stabilize the situation as fast as I can.

@olafhering
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is tempting to move a tag, to satisfy an ambition for a bugfree dot-zero release, despite all the blurb in the On Re-tagging paragraph.

If the new shiny release arrives as 0.18.π in opam, that will be fine I think.

But, maybe I just missed the "pre-release" part in the notification email. Will look for it next time. Thanks!

Please sign in to comment.