Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Better PDF 2 Plugin #2048

Closed
wants to merge 1 commit into from
Closed

Add Better PDF 2 Plugin #2048

wants to merge 1 commit into from

Conversation

joleaf
Copy link
Contributor

@joleaf joleaf commented Jun 15, 2023

I am submitting a new Community Plugin

NOTE: The original "Better PDF" plugin does not work in the latest obsidian version and the author does not respond to the related issue. Thus, this plugin is an updated fork of this plugin with a new maintainer. Optional: Delete the original better-pdf-plugin from the community-plugins.json list?

Repo URL

Link to my plugin:
https://github.com/joleaf/obsidian-better-pdf-2-plugin

Release Checklist

  • I have tested the plugin on
    • Windows
    • macOS
    • Linux
    • Android (if applicable)
    • iOS (if applicable)
  • My GitHub release contains all required files
    • main.js
    • manifest.json
    • styles.css (optional)
  • GitHub release name matches the exact version number specified in my manifest.json (Note: Use the exact version number, don't include a prefix v)
  • The id in my manifest.json matches the id in the community-plugins.json file.
  • My README.md describes the plugin's purpose and provides clear usage instructions.
  • I have read the tips in https://github.com/obsidianmd/obsidian-releases/blob/master/plugin-review.md and have self-reviewed my plugin to avoid these common pitfalls.
  • I have added a license in the LICENSE file.
  • My project respects and is compatible with the original license of any code from other plugins that I'm using.
    I have given proper attribution to these other projects in my README.md.

@joleaf
Copy link
Contributor Author

joleaf commented Jun 15, 2023

Close for now, as there are major bugs

@joleaf joleaf closed this Jun 15, 2023
@joleaf joleaf reopened this Jun 16, 2023
@joleaf
Copy link
Contributor Author

joleaf commented Jun 16, 2023

Close for now, as there are major bugs

Working now

@joethei
Copy link
Collaborator

joethei commented Jun 16, 2023

As the original "Better PDF" plugin does not have any license, we can't accept this submission.
Please see our Developer Policies

Sorry about that!

@joethei joethei closed this Jun 16, 2023
@joleaf
Copy link
Contributor Author

joleaf commented Jun 17, 2023

As the original "Better PDF" plugin does not have any license, we can't accept this submission. Please see our Developer Policies

Sorry about that!

Hey @joethei , I understand. Is there another way that all the users used Better PDF dont need to relay on an old obsidian version to make better pdf functional? Because, with the latest obsidian version, the plugin can not be enabled anymore.

@joleaf
Copy link
Contributor Author

joleaf commented Jul 1, 2023

Sry again @joethei , but is there a way we can publish the Better PDF 2 plugin somehow? The obsidian Developer Policies says that a plugin is removed if a plugin "have become unmaintained or severely broken". The Better PDF Plugin is broken.. Thus can we remove the original PDF plugin and add this here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants