-
Notifications
You must be signed in to change notification settings - Fork 49
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #558 from obophenotype/fixing_ref_violations
Fixing ref violations
- Loading branch information
Showing
9 changed files
with
584,095 additions
and
29,140 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,193 @@ | ||
These notes are for the EDITORS of cl | ||
|
||
This project was created using the [ontology development kit](https://github.com/INCATools/ontology-development-kit). See the site for details. | ||
|
||
For more details on ontology management, please see the [OBO tutorial](https://github.com/jamesaoverton/obo-tutorial) or the [Gene Ontology Editors Tutorial](https://go-protege-tutorial.readthedocs.io/en/latest/) | ||
|
||
You may also want to read the [GO ontology editors guide](http://go-ontology.readthedocs.org/) | ||
|
||
## Requirements | ||
|
||
1. Protege (for editing) | ||
2. A git client (we assume command line git) | ||
3. [docker](https://www.docker.com/get-docker) (for managing releases) | ||
|
||
## Editors Version | ||
|
||
Make sure you have an ID range in the [idranges file](cl-idranges.owl) | ||
|
||
If you do not have one, get one from the maintainer of this repo. | ||
|
||
The editors version is [cl-edit.owl](cl-edit.owl) | ||
|
||
** DO NOT EDIT cl.obo OR cl.owl in the top level directory ** | ||
|
||
[../../cl.owl](../../cl.owl) is the release version | ||
|
||
To edit, open the file in Protege. First make sure you have the repository cloned, see [the GitHub project](https://github.com/obophenotype/cell-ontology) for details. | ||
|
||
You should discuss the git workflow you should use with the maintainer | ||
of this repo, who should document it here. If you are the maintainer, | ||
you can contact the odk developers for assistance. You may want to | ||
copy the flow an existing project, for example GO: [Gene Ontology | ||
Editors Tutorial](https://go-protege-tutorial.readthedocs.io/en/latest/). | ||
|
||
In general, it is bad practice to commit changes to master. It is | ||
better to make changes on a branch, and make Pull Requests. | ||
|
||
## ID Ranges | ||
|
||
These are stored in the file | ||
|
||
* [cl-idranges.owl](cl-idranges.owl) | ||
|
||
** ONLY USE IDs WITHIN YOUR RANGE!! ** | ||
|
||
If you have only just set up this repository, modify the idranges file | ||
and add yourself or other editors. Note Protege does not read the file | ||
- it is up to you to ensure correct Protege configuration. | ||
|
||
|
||
### Setting ID ranges in Protege | ||
|
||
We aim to put this up on the technical docs for OBO on http://obofoundry.org/ | ||
|
||
For now, consult the [GO Tutorial on configuring Protege](http://go-protege-tutorial.readthedocs.io/en/latest/Entities.html#new-entities) | ||
|
||
## Imports | ||
|
||
All import modules are in the [imports/](imports/) folder. | ||
|
||
There are two ways to include new classes in an import module | ||
|
||
1. Reference an external ontology class in the edit ontology. In Protege: "add new entity", then paste in the PURL | ||
2. Add to the imports/cl_terms.txt file | ||
|
||
After doing this, you can run | ||
|
||
`./run.sh make all_imports` | ||
|
||
to regenerate imports. | ||
|
||
Note: the cl_terms.txt file may include 'starter' classes seeded from | ||
the ontology starter kit. It is safe to remove these. | ||
|
||
## Design patterns | ||
|
||
You can automate (class) term generation from design patterns by placing DOSDP | ||
yaml file and tsv files under src/patterns. Any pair of files in this | ||
folder that share a name (apart from the extension) are assumed to be | ||
a DOSDP design pattern and a corresponding tsv specifying terms to | ||
add. | ||
|
||
Design patterns can be used to maintain and generate complete terms | ||
(names, definitions, synonyms etc) or to generate logical axioms | ||
only, with other axioms being maintained in editors file. This can be | ||
specified on a per-term basis in the TSV file. | ||
|
||
Design pattern docs are checked for validity via Travis, but can be | ||
tested locally using | ||
|
||
`./run.sh make patterns` | ||
|
||
In addition to running standard tests, this command generates an owl | ||
file (`src/patterns/pattern.owl`), which demonstrates the relationships | ||
between design patterns. | ||
|
||
(At the time of writing, the following import statements need to be | ||
,lsadded to `src/patterns/pattern.owl` for all imports generated in | ||
`src/imports/*_import.owl`. This will be automated in a future release.') | ||
|
||
To compile design patterns to terms run: | ||
|
||
`./run.sh make ../patterns/definitions.owl` | ||
|
||
This generates a file (`src/patterns/definitions.owl`). You then need | ||
to add an import statement to the editor's file to import the | ||
definitions file. | ||
|
||
|
||
## Release Manager notes | ||
|
||
You should only attempt to make a release AFTER the edit version is | ||
committed and pushed, AND the travis build passes. | ||
|
||
These instructions assume you have | ||
[docker](https://www.docker.com/get-docker). This folder has a script | ||
[run.sh](run.sh) that wraps docker commands. | ||
|
||
to release: | ||
|
||
first type | ||
|
||
git branch | ||
|
||
to make sure you are on master | ||
|
||
cd src/ontology | ||
./build.sh | ||
|
||
If this looks good type: | ||
|
||
./prepare_release.sh | ||
|
||
This generates derived files such as cl.owl and cl.obo and places | ||
them in the top level (../..). | ||
|
||
Note that the versionIRI value automatically will be added, and will | ||
end with YYYY-MM-DD, as per OBO guidelines. | ||
|
||
Commit and push these files. | ||
|
||
git commit -a | ||
|
||
And type a brief description of the release in the editor window | ||
|
||
Finally type: | ||
|
||
git push origin master | ||
|
||
IMMEDIATELY AFTERWARDS (do *not* make further modifications) go here: | ||
|
||
* https://github.com/obophenotype/cell-ontology/releases | ||
* https://github.com/obophenotype/cell-ontology/releases/new | ||
|
||
__IMPORTANT__: The value of the "Tag version" field MUST be | ||
|
||
vYYYY-MM-DD | ||
|
||
The initial lowercase "v" is REQUIRED. The YYYY-MM-DD *must* match | ||
what is in the `owl:versionIRI` of the derived cl.owl (`data-version` in | ||
cl.obo). This will be today's date. | ||
|
||
This cannot be changed after the fact, be sure to get this right! | ||
|
||
Release title should be YYYY-MM-DD, optionally followed by a title (e.g. "january release") | ||
|
||
You can also add release notes (this can also be done after the fact). These are in markdown format. | ||
In future we will have better tools for auto-generating release notes. | ||
|
||
Then click "publish release" | ||
|
||
__IMPORTANT__: NO MORE THAN ONE RELEASE PER DAY. | ||
|
||
The PURLs are already configured to pull from github. This means that | ||
BOTH ontology purls and versioned ontology purls will resolve to the | ||
correct ontologies. Try it! | ||
|
||
* http://purl.obolibrary.org/obo/cl.owl <-- current ontology PURL | ||
* http://purl.obolibrary.org/obo/cl/releases/YYYY-MM-DD.owl <-- change to the release you just made | ||
|
||
For questions on this contact Chris Mungall or email obo-admin AT obofoundry.org | ||
|
||
# Travis Continuous Integration System | ||
|
||
Check the build status here: [![Build Status](https://travis-ci.org/obophenotype/cell-ontology.svg?branch=master)](https://travis-ci.org/obophenotype/cell-ontology) | ||
|
||
Note: if you have only just created this project you will need to authorize travis for this repo. | ||
|
||
1. Go to [https://travis-ci.org/profile/obophenotype](https://travis-ci.org/profile/obophenotype) | ||
2. click the "Sync account" button | ||
3. Click the tick symbol next to cell-ontology | ||
|
||
Travis builds should now be activated |
Oops, something went wrong.