Added new protein term #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ar-ibrahim
commented
Sep 11, 2023
ar-ibrahim
commented
- related to issue New term request for Boahen PMID: 36865558 EBISPOT/efo#2087
rays22
requested changes
Sep 11, 2023
| OBA:2050067 blood cadmium amount CHEBI:22977 cadmium atom PATO:0000070 amount UBERON:0000178 blood | ||
| OBA:2050068 serum albumin amount PR:000003918 albumin PATO:0000070 amount UBERON:0001977 serum | ||
| OBA:2050070 serum IgM amount GO:0071754 IgM immunoglobulin complex, circulating PATO:0000070 amount UBERON:0001977 serum | ||
| OBA:0000016 angiotensin levels in blood PR:000036009 angiotensin II PATO:0000070 amount UBERON:0000178 blood |
There was a problem hiding this comment.
The tab separators for the last columns are missing here and at many similar places.
There was a problem hiding this comment.
There are still tab characters missing here and elsewhere in the tsv file.
- edited in different text editor (VS Code) to fix tab characters issue - added additional synonym
rays22
requested changes
Sep 12, 2023
There was a problem hiding this comment.
You need to fix the missing tab characters in the file entity_attribute_location.tsv.
I suggest you follow the instructions I sent you on slack last week.
I am copying and pasting the text here for your convenience.
- Save your new line somewhere outside of github control:
OBA:2050349 level of interleukin-12 subunit beta in blood PR:000001369 interleukin-12 subunit beta PATO:0000070 amount UBERON:0000178 blood
- Replace the
entity_attribute_location.tsvfile in your branch with a fresh copy from the master branch (which should have the correct tab characters). - Import/open the file
entity_attribute_location.tsvin google sheets (or similar). Add back your new term:
OBA:2050349 level of interleukin-12 subunit beta in blood PR:000001369 interleukin-12 subunit beta PATO:0000070 amount UBERON:0000178 blood
- Export the updated table as tsv and replace the
entity_attribute_location.tsvfile with your edited copy. Check the git diff and the tsv file should show changes at the last line(s) that you added and the tab characters should be retained for empty columns.
| OBA:2050067 blood cadmium amount CHEBI:22977 cadmium atom PATO:0000070 amount UBERON:0000178 blood | ||
| OBA:2050068 serum albumin amount PR:000003918 albumin PATO:0000070 amount UBERON:0001977 serum | ||
| OBA:2050070 serum IgM amount GO:0071754 IgM immunoglobulin complex, circulating PATO:0000070 amount UBERON:0001977 serum | ||
| OBA:0000016 angiotensin levels in blood PR:000036009 angiotensin II PATO:0000070 amount UBERON:0000178 blood |
There was a problem hiding this comment.
There are still tab characters missing here and elsewhere in the tsv file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.