Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix synonym, xref and orcid data list variables #287

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Fix synonym, xref and orcid data list variables #287

merged 2 commits into from
Sep 4, 2023

Conversation

rays22
Copy link
Contributor

@rays22 rays22 commented Aug 31, 2023

This commit intends to

  1. Fix or add the capability of the entity_attribute and entity_attribute_location templates to accept lists of exact synonyms and external database references.
  2. Add the capability of the entity_attribute and entity_attribute_location templates to accept lists of contributor ORCIDs. If applied, this commit will fix Fix exact synonym list variables in DOS-DP templates #286.

@rays22
Fix synonym, xref and orcid data list variables
07d940b 
This commit intends to
1. Fix or add the capability of the entity_attribute and entity_attribute_location templates to accept lists of exact synonyms and external database references.
2. Add the capability of  the entity_attribute and entity_attribute_location templates to accept lists of contributor ORCIDs.
If applied, this commit will fix #286.
@rays22 rays22 requested a review from ar-ibrahim August 31, 2023 18:58
@rays22 rays22 self-assigned this Aug 31, 2023
@rays22
Copy link
Contributor Author

rays22 commented Aug 31, 2023

Related to EBISPOT/efo#2059

ar-ibrahim
ar-ibrahim approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@ar-ibrahim ar-ibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Synonyms and x-refs can both be added now. I also tried adding more than one synonym and it worked as well.

@rays22 rays22 merged commit 2db2eac into master Sep 4, 2023
@rays22 rays22 deleted the issue286 branch September 4, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ar-ibrahim ar-ibrahim ar-ibrahim approved these changes

Assignees

@rays22 rays22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix exact synonym list variables in DOS-DP templates
2 participants
@rays22 @ar-ibrahim