Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kaja/add biome #73

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Kaja/add biome #73

wants to merge 3 commits into from

Conversation

kaja-osojnik
Copy link
Contributor

Implementing the Biome tool for formatting and linting and fixing issues or errors flagged during the formatting process.

Copy link

netlify bot commented Aug 29, 2024

Deploy Preview for oasisprotocol-playground ready!

Name Link
🔨 Latest commit 39e6516
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-playground/deploys/66d1a3f4e9a92a00085df44e
😎 Deploy Preview https://deploy-preview-73--oasisprotocol-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matevz
Copy link
Member

matevz commented Aug 29, 2024

In other projects we simply use https://www.npmjs.com/package/prettier. Any reason why not to use it here too? Also what's with the 8 chars per tab? Usually it's 4 or 2.

@kaja-osojnik
Copy link
Contributor Author

In other projects we simply use https://www.npmjs.com/package/prettier. Any reason why not to use it here too? Also what's with the 8 chars per tab? Usually it's 4 or 2.

@lukaw3d recommended Biome. For spacing - it seems like that was a default setting, changed it to 2-spaced indentation.

@lukaw3d
Copy link
Member

lukaw3d commented Aug 30, 2024

I prefer eslint+prettier. But that will require a week of senior frontend engineer time when migrating to next version of either.

Biome is fine. Or, if Nick is listening, https://github.com/xojs/xo. But configuring vscode for each is risky and annoying, so I just run them in console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants