ROFL instructions for Localnet #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for oasisprotocol-oasis-sdk failed.
|
matevz
force-pushed
the
matevz/feature/rofl-localnet
branch
from
915a0d3
to
55145c6
Compare
matevz
requested review from
kostko,
pro-wh,
ptrus and
peternose
as code owners
kostko
reviewed
Sep 19, 2024
There was a problem hiding this comment.
The "How do ROFL Apps Work" currently has this text:
For the rest of this chapter we will be using Sapphire Testnet which has all of the required functionality.
This should be changed to somehow say that we will be deploying either on Localnet or on Sapphire Testnet. An alternative would be to completely separate and have two chapters:
- Deploying an UNSAFE debug version on Localnet.
- Deploying in production to Testnet and Mainnet.
I think the current mixing of the two is somewhat confusing.
matevz
force-pushed
the
matevz/feature/rofl-localnet
branch
6 times, most recently
from
aeb26a6
to
b483e09
Compare
matevz
force-pushed
the
matevz/feature/rofl-localnet
branch
3 times, most recently
from
1e23866
to
7c2fdcd
Compare
abukosek
reviewed
Sep 19, 2024
- move deploy script to task - remove sapphire-hardhat as it's not needed - simplify commands and docs
matevz
force-pushed
the
matevz/feature/rofl-localnet
branch
from
7c2fdcd
to
39f5e49
Compare
abukosek
approved these changes
Sep 19, 2024
|
Let's merge this so we have a documented ROFL Localnet usage and open subsequent followup PRs. |
matevz
force-pushed
the
matevz/feature/rofl-localnet
branch
from
39f5e49
to
288f39b
Compare
matevz
force-pushed
the
matevz/feature/rofl-localnet
branch
from
288f39b
to
52943a8
Compare
ptrus
approved these changes
Sep 19, 2024
github-actions bot
added a commit
that referenced
this pull request
Sep 20, 2024
…atevz/feature/rofl-localnet ROFL instructions for Localnet 2dd7e57
github-actions bot
added a commit
that referenced
this pull request
Sep 20, 2024
…/matevz/feature/rofl-localnet ROFL instructions for Localnet 2dd7e57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.