go/upgrade: Adjust MaxTxSize and MaxBlockSize in consensus240 handler

[kostko]

This is needed as DCAP quotes are larger and nodes running multiple confidential runtimes may otherwise exceed the max transaction size.

[netlify]

✅ Deploy Preview for oasisprotocol-oasis-core canceled.

Name	Link
🔨 Latest commit	4944990
🔍 Latest deploy log	https://app.netlify.com/sites/oasisprotocol-oasis-core/deploys/65eab961e2ec7b0008d193df

[ptrus]

Probably makes sense to also update defaults in

oasis-core/go/oasis-node/cmd/genesis/genesis.go

Lines 856 to 857 in dc8256d

	initGenesisFlags.String(cfgConsensusMaxTxSizeBytes, "32kb", "cometbft maximum transaction size (in bytes)")
	initGenesisFlags.String(cfgConsensusMaxBlockSizeBytes, "21mb", "cometbft maximum block size (in bytes)")

[codecov]

Codecov Report

Attention: Patch coverage is 44.44444% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 65.94%. Comparing base (ea412e2) to head (90a6df2).
Report is 5 commits behind head on master.

❗ Current head 90a6df2 differs from pull request most recent head 4944990. Consider uploading reports for the commit 4944990 to get more accurate results

Files	Patch %	Lines
go/upgrade/migrations/consensus_240.go	44.44%	2 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5588      +/-   ##
==========================================
+ Coverage   65.89%   65.94%   +0.04%     
==========================================
  Files         577      577              
  Lines       58879    58887       +8     
==========================================
+ Hits        38799    38833      +34     
+ Misses      15567    15533      -34     
- Partials     4513     4521       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[kostko]

Probably makes sense to also update defaults in

But then it won't update anything in tests.

[peternose]

But then it won't update anything in tests.

in this case, I like to prepare a draft PR which we can merge as soon as we do the upgrade.

[kostko]

in this case, I like to prepare a draft PR which we can merge as soon as we do the upgrade.

Good idea, I'll do that.

[kostko]

#5591