Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add derive symmetric key unit test for X25519-Deoxys-II MRAE scheme #4772

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

xmzheng
Copy link

@xmzheng xmzheng commented Jun 1, 2022

add same test logic for derive_symmetric_key for golang, rust, which should be identical to those in oasis-sdk/client-sdk/web-ts

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix commit message, squash into a single commit as the second commit is just a fixup, add a changelog fragment.

@@ -56,6 +56,7 @@ oid-registry = "0.4.0"
rsa = "0.5.0"
base64-serde = "0.6.1"
lru = "0.7.5"
hex = "0.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be under dev-dependencies as it is only used in tests.

@kostko kostko changed the title add same unittest for derive_symmetric_key of client-sdk/web-ts for g… Add derive symmetric key unit test for X25519-Deoxys-II MRAE scheme Jun 1, 2022
@kostko kostko added the c:testing Category: testing label Jun 1, 2022
@xmzheng xmzheng force-pushed the xmzheng/unittest_derive_symmetric_key branch from c916b87 to 6875fac Compare June 21, 2022 16:00
Copy link
Contributor

@nhynes nhynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you could make a note of where you acquired the test vectors, this PR looks good to me

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests seem fine, please address the remaining commit/lint-related comments.

@@ -67,6 +67,7 @@ features = ["full"]

[dev-dependencies]
# For storage interoperability tests only.
hex = "0.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be moved below as the above comment applies to the jsonrpc dependency.

@kostko
Copy link
Member

kostko commented Aug 22, 2022

@xmzheng ping on addressing the remaining issues and merging this.

@xmzheng xmzheng force-pushed the xmzheng/unittest_derive_symmetric_key branch from 6875fac to cd7b0fc Compare August 23, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:testing Category: testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants