Add annotations, update deprecations, enforce consistent style with stylua, improve stuff.
#25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tried to guess what your preffered style was, so I configured the `.stylua.toml` file accordingly. In addition, I added a couple of prototype annotations for easier understanding of what the code does, but I need your input on this.
Converted to `vim.api.nvim_set_option_value` as the ones you were using were deprecated and would lead to warnings.
I find using `... in next, table do ...` more consistent and better overall for use in for loops. What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DON'T MERGE THIS YET, INCOMPLETE PULL REQUEST AS I NEED YOUR INPUT ON THIS.
My Ideas
I plan to write annotations and documentation for this plugin to better communicate to the end user
how utilities should be used and what they do. Also planning to build upon pending stuff.
I have successfully corrected the use of deprecated code in line with more modern versions of nvim.
In addition, I have updated the
README.mdto include more installation methods,and intend to write a more complete overview that'll include instructions and examples.
Finally I have implemented
styluato enforce a consistent style of code to improve code readability.Your Turn
I need to know what you think, what you want me to do and what should I take into account.
I hope we can work together as I'm legitimately interested in helping you out.
If you need any reference for what I can do with Nvim Lua you can check my custom config as to assess whether I can provide any meaningful assistance.
Have a nice day!