Skip to content
This repository has been archived by the owner on Oct 13, 2021. It is now read-only.

Change handler signature #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaelsq
Copy link

@rafaelsq rafaelsq commented Sep 9, 2021

Completion-nvim is broken for nvim >= 0.5.1
The signature changed from function(err, method, result, client_id, bufnr, config) to function(err, result, ctx, config).

ref; neovim/neovim#15504

@ranjithshegde
Copy link
Contributor

@rafaelsq thanks. beat me to it. I have had it working on my local, just never got to filing the PR. Will test this

@mrkz
Copy link

mrkz commented Sep 29, 2021

I can confirm that this PR fixed #399 for me

@rafaelsq
Copy link
Author

@vigoux Could you please review or approve this?

@verrchu
Copy link

verrchu commented Oct 1, 2021

this fix works
pls merge it

kieron-dev pushed a commit to eirini-forks/eirini-station that referenced this pull request Oct 5, 2021
nvim-completion is struggling to adapt to the changed API: nvim-lua/completion-nvim#400
@Shougo Shougo mentioned this pull request Oct 8, 2021
@mrkz
Copy link

mrkz commented Oct 12, 2021

friendly bump

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants