removeUrlParams #48
Merged
removeUrlParams #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reating placeMarkers files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
None, reported privately.
Summary of the issue:
URL parameters after question mark are considered when saving bookmarks. This may make bookmarks invalid for the same website between different sessions.
Description of how this pull request fixes the issue:
Remove characters after the question mark when calculating files where bookmarks are placed.
Testing performed:
Tested locally in DuckDuckGo webpage, and tested by the reporter.
Known issues with pull request:
Previously calculation of bookmark files considered URL parameters. If someone wants to switch to the previous behavior, an add-on settings panel maybe use to select this.
Change log entry: