fix(js): fix Rollup plugin to correctly handle .cjs.js and .mjs.js fi… #29366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
Your CI Pipeline Execution ↗ for commit da02a50 ⏳ is in progress.
Last updated at 2024-12-16 14:41:45UTC Sent with 💌 from NxCloud. |
…le extensions for type definitions. Updated the Rollup plugin's logic for generating type definition files to ensure compatibility with additional file extensions, including .cjs.js and .mjs.js. This change improves the handling of entry points and ensures that corresponding .d.ts files are correctly named and emitted in all supported scenarios. Added a comprehensive test case to validate the new behavior. closed nrwl#29308
ashkanhosseini
force-pushed
the
fix/29308-d-ts-file-formats
branch
from
bd7d7e5 to
da02a50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…le extensions for type definitions.
Updated the Rollup plugin's logic for generating type definition files to ensure compatibility with additional file extensions, including .cjs.js and .mjs.js.
This change improves the handling of entry points and ensures that corresponding .d.ts files are correctly named and emitted in all supported scenarios.
Added a comprehensive test case to validate the new behavior.
closed #29308
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #